Re: STAGING:iio:light: fix ISL29018 init to handle brownout

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 30, 2011 at 3:05 AM, Jonathan Cameron <jic23@xxxxxxxxx> wrote:
....
>> I did change one basic behavior that I think was also broken: cache
>> the value regardless of if the transaction completed successfully or
>> not.
> Don't do that.  That means userspace will get an invalid value if it reads
> in the meantime. If you have an error on a hardware bus - tell userspace about
> it and don't 'guess' what is in the register.

Ah ok - I didn't know this was part of the path to/from user space.

>
> Otherwise patch looks fine to me.

OK - I'll restore previous behavior and submit another patch.

cheers!
grant
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux