On Thu, Aug 25, 2011 at 02:07:05PM -0500, Larry Finger wrote:
> @@ -1867,7 +1868,7 @@ void rtl8192_TranslateRxSignalStuff(struct net_device *dev, struct sk_buff *skb,
> (fc & RTLLIB_FCTL_TODS) ? hdr->addr1 :
> (fc & RTLLIB_FCTL_FROMDS) ? hdr->addr2 : hdr->addr3))
> && (!pstats->bHwError) && (!pstats->bCRC) && (!pstats->bICV));
> - bpacket_toself = bpacket_match_bssid &
> + bpacket_toself = bpacket_match_bssid && /* check this */
^^^^^^^^^^^^
You're wondering if the change is correct? It looks ok to me.
You're comparing boolean to boolean so "&" and "&&" are basically
equivelent but "&&" is cleaner. (I say basically equivalent, because
&& has different ordering guarantees).
> (!compare_ether_addr(praddr,
> priv->rtllib->dev->dev_addr));
> if (WLAN_FC_GET_FRAMETYPE(fc) == RTLLIB_STYPE_BEACON)
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
