On Thu, Aug 25, 2011 at 11:48:30AM -0500, Larry Finger wrote: > @@ -68,81 +64,73 @@ int rtl8192E_suspend (struct pci_dev *pdev, pm_message_t state) > write_nic_byte(dev, MacBlkCtrl, 0xa); > } > out_pci_suspend: > - RT_TRACE(COMP_POWER, "r8192E support WOL call??????????????????????\n"); > printk("r8192E support WOL call??????????????????????\n"); > - if (priv->rtllib->bSupportRemoteWakeUp) { > - RT_TRACE(COMP_POWER, "r8192E support WOL call!!!!!!!!!!!!!!!!!!.\n"); > - } > + if (priv->rtllib->bSupportRemoteWakeUp) > + RT_TRACE(COMP_POWER, "r8192E support WOL call!!!!!!!" > + "!!!!!!!!!!!.\n"); Kernel style says you should never use more than 15 exclamation marks but there are 18 here. And a period. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel