Re: [PATCH 0/5] staging: r8712u: Merging Realtek's latest (v2.6.6).

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Larry,


On Tue, Aug 23, 2011 at 01:53:36PM +0800, Ali Bahar wrote:
> Merged the changes from Realtek's v2.6.6.0.20110401 release.
> 
> Some notes:
> 
> Contrary to Realtek's release, linux's 64-bit support has been maintained
> (by keeping the addr_t type.)
> 
> Tx Aggregation (CONFIG_R8712_TX_AGGR, known as CONFIG_USB_TX_AGGR in the
> Realtek tarball) is included, but may have issues. The default in the Realtek
> tarball is to not build it -- nor does the Release Notes seem to list this as a
> feature. I have built the patches with and without this feature; the former
> does not associate when WPA/TKIP is used. It is TBD whether this is a
> supplicant issue, or of the new Realtek code, etc.
> 
> In rtl871x_mp.c's SetSingleCarrierTx(), the new comment did not match the
> code, and so has been skipped. (Did they intend to change the code as well?)
> 
> The firmware update, in farray.h, has already been submitted by Larry Finger.
> 
> wlan_network.last_scanned is now a long, and uncast in _free_network(). 
> Type-wise, though (one expects) not in practice, it can be larger than
> curr_time. (delta_time will remain unsigned, but will be wrong.)

please note that the last_scanned mod will not be in the coming patch
set: it breaks functioning code. (See patch 5 in the current patch set;
basically, it changed from an int to a long.)
I added it as an isolated delta (ie only the last_scanned mods) to
code that was confirmed as functional. Then a basic association failed.

I have not gotten to the bottom of it, because I have been busy with
a more serious problem. (See my next email.) The type-change does not
make sense; and, since it breaks the code, it is best skipped!

Why did it not break last week? I think if/when it did occur, I might
have attributed it to a flawed AP. It does not seem to reproduce
consistently.

regards,
ali


 
> 
> Ali Bahar (5):
>   staging: r8712u: Merging Realtek's latest (v2.6.6). Added copyright
>     banners.
>   staging: r8712u: Merging Realtek's latest (v2.6.6). Added Larry's
>     copyright.
>   staging: r8712u: Merging Realtek's latest. A few types and
>     definitions.
>   staging: r8712u: Merging Realtek's latest. Mostly types, defines and
>     includes.
>   staging: r8712u: Merging Realtek's latest (v2.6.6). Various fixes.
> 
>  drivers/staging/rtl8712/Kconfig                    |    7 +
>  drivers/staging/rtl8712/basic_types.h              |   25 ++
>  drivers/staging/rtl8712/big_endian.h               |   25 ++
>  drivers/staging/rtl8712/drv_types.h                |   28 ++
>  drivers/staging/rtl8712/ethernet.h                 |   25 ++
>  drivers/staging/rtl8712/generic.h                  |   25 ++
>  drivers/staging/rtl8712/hal_init.c                 |    5 +
>  drivers/staging/rtl8712/ieee80211.c                |   35 +---
>  drivers/staging/rtl8712/ieee80211.h                |   31 ++-
>  drivers/staging/rtl8712/if_ether.h                 |   25 ++
>  drivers/staging/rtl8712/little_endian.h            |   25 ++
>  drivers/staging/rtl8712/mlme_osdep.h               |   25 ++
>  drivers/staging/rtl8712/mp_custom_oid.h            |   25 ++
>  drivers/staging/rtl8712/os_intfs.c                 |   19 +-
>  drivers/staging/rtl8712/osdep_intf.h               |   27 ++
>  drivers/staging/rtl8712/osdep_service.h            |   68 ++---
>  drivers/staging/rtl8712/recv_linux.c               |    6 +-
>  drivers/staging/rtl8712/recv_osdep.h               |   25 ++
>  drivers/staging/rtl8712/rtl8712_bitdef.h           |   21 ++
>  drivers/staging/rtl8712/rtl8712_cmd.c              |   22 ++-
>  drivers/staging/rtl8712/rtl8712_cmd.h              |   90 ++++++
>  drivers/staging/rtl8712/rtl8712_cmdctrl_bitdef.h   |   19 ++
>  drivers/staging/rtl8712/rtl8712_cmdctrl_regdef.h   |   19 ++
>  drivers/staging/rtl8712/rtl8712_debugctrl_bitdef.h |   19 ++
>  drivers/staging/rtl8712/rtl8712_debugctrl_regdef.h |   19 ++
>  .../staging/rtl8712/rtl8712_edcasetting_bitdef.h   |   25 ++
>  .../staging/rtl8712/rtl8712_edcasetting_regdef.h   |   19 ++
>  drivers/staging/rtl8712/rtl8712_efuse.c            |   99 ++++---
>  drivers/staging/rtl8712/rtl8712_event.h            |   25 ++
>  drivers/staging/rtl8712/rtl8712_fifoctrl_bitdef.h  |   19 ++
>  drivers/staging/rtl8712/rtl8712_fifoctrl_regdef.h  |   19 ++
>  drivers/staging/rtl8712/rtl8712_gp_bitdef.h        |   25 ++
>  drivers/staging/rtl8712/rtl8712_gp_regdef.h        |   25 ++
>  drivers/staging/rtl8712/rtl8712_hal.h              |   25 ++
>  drivers/staging/rtl8712/rtl8712_interrupt_bitdef.h |   19 ++
>  drivers/staging/rtl8712/rtl8712_led.c              |    2 +-
>  .../staging/rtl8712/rtl8712_macsetting_bitdef.h    |   19 ++
>  .../staging/rtl8712/rtl8712_macsetting_regdef.h    |   19 ++
>  drivers/staging/rtl8712/rtl8712_powersave_bitdef.h |   19 ++
>  drivers/staging/rtl8712/rtl8712_powersave_regdef.h |   19 ++
>  drivers/staging/rtl8712/rtl8712_ratectrl_bitdef.h  |   19 ++
>  drivers/staging/rtl8712/rtl8712_ratectrl_regdef.h  |   25 ++
>  drivers/staging/rtl8712/rtl8712_recv.c             |   51 ++--
>  drivers/staging/rtl8712/rtl8712_recv.h             |   29 ++-
>  drivers/staging/rtl8712/rtl8712_regdef.h           |   25 ++
>  drivers/staging/rtl8712/rtl8712_security_bitdef.h  |   19 ++
>  drivers/staging/rtl8712/rtl8712_spec.h             |   25 ++
>  drivers/staging/rtl8712/rtl8712_syscfg_bitdef.h    |   25 ++
>  drivers/staging/rtl8712/rtl8712_syscfg_regdef.h    |   25 ++
>  drivers/staging/rtl8712/rtl8712_timectrl_bitdef.h  |   19 ++
>  drivers/staging/rtl8712/rtl8712_timectrl_regdef.h  |   19 ++
>  drivers/staging/rtl8712/rtl8712_wmac_bitdef.h      |   25 ++
>  drivers/staging/rtl8712/rtl8712_wmac_regdef.h      |   25 ++
>  drivers/staging/rtl8712/rtl8712_xmit.c             |  303 ++++++++++++++++++--
>  drivers/staging/rtl8712/rtl8712_xmit.h             |   39 +++
>  drivers/staging/rtl8712/rtl871x_byteorder.h        |   19 ++
>  drivers/staging/rtl8712/rtl871x_cmd.c              |  168 ++++++++++-
>  drivers/staging/rtl8712/rtl871x_cmd.h              |   79 +++++-
>  drivers/staging/rtl8712/rtl871x_debug.h            |   25 ++
>  drivers/staging/rtl8712/rtl871x_eeprom.h           |   19 ++
>  drivers/staging/rtl8712/rtl871x_event.h            |   25 ++
>  drivers/staging/rtl8712/rtl871x_ht.h               |   25 ++
>  drivers/staging/rtl8712/rtl871x_io.h               |   25 ++
>  drivers/staging/rtl8712/rtl871x_ioctl_linux.c      |  287 +++++++++++++------
>  drivers/staging/rtl8712/rtl871x_ioctl_rtl.c        |   40 +++
>  drivers/staging/rtl8712/rtl871x_ioctl_rtl.h        |   29 ++
>  drivers/staging/rtl8712/rtl871x_ioctl_set.h        |   25 ++
>  drivers/staging/rtl8712/rtl871x_led.h              |   25 ++
>  drivers/staging/rtl8712/rtl871x_mlme.c             |   76 ++----
>  drivers/staging/rtl8712/rtl871x_mlme.h             |   28 ++-
>  drivers/staging/rtl8712/rtl871x_mp.c               |   26 ++-
>  drivers/staging/rtl8712/rtl871x_mp.h               |   25 ++
>  drivers/staging/rtl8712/rtl871x_mp_ioctl.c         |   25 ++
>  drivers/staging/rtl8712/rtl871x_mp_ioctl.h         |   28 ++-
>  drivers/staging/rtl8712/rtl871x_pwrctrl.h          |   25 ++
>  drivers/staging/rtl8712/rtl871x_rf.h               |   25 ++
>  drivers/staging/rtl8712/rtl871x_security.c         |   40 ++-
>  drivers/staging/rtl8712/rtl871x_security.h         |   25 ++
>  drivers/staging/rtl8712/rtl871x_wlan_sme.h         |   25 ++
>  drivers/staging/rtl8712/rtl871x_xmit.c             |   37 ++-
>  drivers/staging/rtl8712/rtl871x_xmit.h             |   50 +++-
>  drivers/staging/rtl8712/sta_info.h                 |   29 ++-
>  drivers/staging/rtl8712/swab.h                     |   25 ++
>  drivers/staging/rtl8712/usb_intf.c                 |   32 ++-
>  drivers/staging/rtl8712/usb_ops.h                  |   25 ++
>  drivers/staging/rtl8712/usb_ops_linux.c            |   42 ++--
>  drivers/staging/rtl8712/usb_osintf.h               |   26 ++
>  drivers/staging/rtl8712/usb_vendor_req.h           |   25 ++
>  drivers/staging/rtl8712/wifi.h                     |   26 ++
>  drivers/staging/rtl8712/wlan_bssdef.h              |   27 ++-
>  drivers/staging/rtl8712/xmit_linux.c               |   26 ++-
>  drivers/staging/rtl8712/xmit_osdep.h               |   26 ++
>  92 files changed, 2830 insertions(+), 416 deletions(-)
> 
> -- 
> 1.7.6
> 
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux