Re: [PATCH V2] staging: rtl8192e: Fix array overrun

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 26, 2011 at 04:46:28PM -0500, Larry Finger wrote:
> Smatch outputs the following message:
> 
> drivers/staging/rtl8192e/r8192E_cmdpkt.c +412 cmpk_message_handle_rx(70)
> 	error: buffer overflow 'priv->stats.rxcmdpkt' 4 <= 7
> 
>    407                          RT_TRACE(COMP_CMDPKT, "---->cmpk_message_handle_rx():"
>    408                                   "unknow CMD Element\n");
>    409                          return 1;
>    410                  }
>    411
>    412                  priv->stats.rxcmdpkt[element_id]++;
>                                              ^^^^^^^^^^
> ->stats.rxcmdpkt[] only has 4 elements, but from the switch statement
> in the section before we can see that element_id can go up to 7
> (RX_TX_RATE_HISTORY).
> 
> Reported-by: Dan Carpenter <error27@xxxxxxxxx>
> Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
> ---
> 
> Greg,
> 
> V2 Change from dimension of 7 to 8
> 
> This patch can be pulled from
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/lwfinger/r8192E.git

$  git pull --log git://git.kernel.org/pub/scm/linux/kernel/git/lwfinger/r8192E.git
>From git://git.kernel.org/pub/scm/linux/kernel/git/lwfinger/r8192E
 * branch            HEAD       -> FETCH_HEAD
 Already up-to-date.
$

What did I do wrong here?  Are you sure you pushed?  I'll just apply the
patch ok?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux