Hey Martyn, These are the updated patches with the discussed issues resolved. Let me know if you spot anything else. A note on the changes: * staging: vme: add functions for bridge module refcounting Fixed the parameter imbalance in vme_bridge_[get|put]. They both now take a struct vme_bridge * as their parameter. I used the vme_bridge * instead of vme_dev as it more coherent with the names of the functions. * staging: vme: add struct vme_dev for VME devices Fixes based on the above changes. * staging: vme: make match() driver specific to improve non-VME64x support Cleaned up the loop in __vme_register_driver with a note on why there is no race involved. Thanks Manohar Manohar Vanga (3): staging: vme: add functions for bridge module refcounting staging: vme: add struct vme_dev for VME devices staging: vme: make match() driver specific to improve non-VME64x support drivers/staging/vme/bridges/vme_ca91cx42.c | 2 + drivers/staging/vme/bridges/vme_tsi148.c | 2 + drivers/staging/vme/devices/vme_user.c | 67 +++---- drivers/staging/vme/devices/vme_user.h | 2 +- drivers/staging/vme/vme.c | 305 +++++++++++++++------------- drivers/staging/vme/vme.h | 55 ++++-- drivers/staging/vme/vme_api.txt | 79 +++++--- drivers/staging/vme/vme_bridge.h | 6 +- 8 files changed, 285 insertions(+), 233 deletions(-) -- 1.7.4.1 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel