It looks good to me, but I don't know anything about the iio code. Jonathan will let you know if there is a problem. :) This is minor thing, but checkpatch complains that: +#define ISL29018_MAX_REGS ISL29018_REG_ADD_DATA_MSB+1 should be written as: +#define ISL29018_MAX_REGS (ISL29018_REG_ADD_DATA_MSB + 1) Thanks Grant. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
