Re: [smatch stuff] xgifb: read outside array inxgifb_probe()?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi,

On Fri, 26 Aug 2011 12:11:22 +0300, Dan Carpenter <error27@xxxxxxxxx> wrote:
Can xgifb_mode_idx be set to -1 here?

drivers/staging/xgifb/XGI_main_26.c +2329 xgifb_probe(302)
	error: testing array offset 'xgifb_mode_idx' after use.

  2189   if (!XGIfb_GetXG21LVDSData()) {
  2190   	int m;
2191 for (m = 0; m < sizeof(XGI21_LCDCapList)/sizeof(struct XGI21_LVDSCapStruct); m++) { 2192 if ((XGI21_LCDCapList[m].LVDSHDE == XGIbios_mode[xgifb_mode_idx].xres) &&

^^^^^^^^^^^^^^

Yes, I think that's possible (happens only with XG21/LCD when the video BIOS is broken). I have actually a patch to fix this, and I was planning to send it next week with some
other fixes related to default video mode setup.

A.

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux