Re: [PATCH] staging: rtl8192e: Fix missing include of vmalloc.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 25, 2011 at 10:31:38AM -0500, Larry Finger wrote:
> From: Stephan Rothwell <sfr@xxxxxxxxxxxxxxxx>
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/staging/rtl8192e/rtl_core.c: In function 'rtl8192_init_priv_variable':
> drivers/staging/rtl8192e/rtl_core.c:1270:2: error: implicit declaration of function 'vmalloc'
> drivers/staging/rtl8192e/rtl_core.c:1270:20: warning: cast to pointer from integer of different size
> drivers/staging/rtl8192e/rtl_core.c: In function 'rtl8192_pci_disconnect':
> drivers/staging/rtl8192e/rtl_core.c:3101:4: error: implicit declaration of function 'vfree'
> 
> Caused by commit 94a799425eee ("rom: wlanfae <wlanfae@xxxxxxxxxxx>"
> really "[PATCH 1/8] rtl8192e: Import new version of driver from realtek").
> 
> Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
> ---

You dropped Stephan's signed-off-by here, which is not ok.

I fixed this up and took Stephan's original patch and added your
signed-off-by.

Please be more careful in the future.

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux