On Wed, Aug 24, 2011 at 12:38:09AM +0000, KY Srinivasan wrote: > > > > -----Original Message----- > > From: Greg KH [mailto:greg@xxxxxxxxx] > > Sent: Tuesday, August 23, 2011 6:50 PM > > To: KY Srinivasan > > Cc: gregkh@xxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > > devel@xxxxxxxxxxxxxxxxxxxxxx; virtualization@xxxxxxxxxxxxxx; Haiyang Zhang > > Subject: Re: [PATCH 019/117] Staging: hv: vmbus: Cleanup vmbus_uevent() code > > > > On Fri, Jul 15, 2011 at 10:46:07AM -0700, K. Y. Srinivasan wrote: > > > Now generate appropriate uevent based on the modalias string. As part of this, > > > cleanup the existing uevent code. > > > > Note, you just change the user api here, did you have tools that relied > > on the old format? If so, they just broke :( > > Prior to this, I don't think autoloading worked the way it should for these > modules. It didn't? How did the mouse driver get autoloaded then, through the pci/dmi tables? > > > + for (i = 0; i < (sizeof(struct hv_vmbus_device_id) * 2); i += 2) > > > + sprintf(&alias_name[i], "%02x", dev->dev_type.b[i/2]); > > > > Don't we have a type for printing out a uuid already? > > I did not see one; could you point me to the right place. > > > > And what's with the jumping by 2 yet dividing? What am I missing here? > > Each byte of the uuid is represented by 2 bytes in the string; thus the magic with 2. Ok, wierd, but it makes sense, thanks. greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
