On 08/23/2011 12:53 AM, Ali Bahar wrote:
Realtek's latest is v2.6.6. A few types and definitions have been updated in
these files.
But rtl871x_recv.h's addr_t change has not been accepted: it will break on
64-bit platforms.
Signed-off-by: Ali Bahar<ali@xxxxxxxxxxxxxxx>
---
drivers/staging/rtl8712/rtl8712_event.h | 25 +++++++++++++++++++++++
drivers/staging/rtl8712/rtl8712_recv.h | 29 +++++++++++++++++++++++++-
drivers/staging/rtl8712/rtl871x_debug.h | 25 +++++++++++++++++++++++
drivers/staging/rtl8712/rtl871x_ioctl_rtl.h | 29 +++++++++++++++++++++++++++
drivers/staging/rtl8712/sta_info.h | 29 +++++++++++++++++++++++++-
drivers/staging/rtl8712/wlan_bssdef.h | 27 ++++++++++++++++++++++++-
6 files changed, 159 insertions(+), 5 deletions(-)
-- snip --
index c48757f..3c766c0 100644
--- a/drivers/staging/rtl8712/rtl8712_recv.h
+++ b/drivers/staging/rtl8712/rtl8712_recv.h
-- snip --
+ ******************************************************************************/
#ifndef _RTL8712_RECV_H_
#define _RTL8712_RECV_H_
#include "osdep_service.h"
#include "drv_types.h"
-#define NR_RECVBUFF (8)
+#define NR_RECVBUFF (4)
Realtek may have made this change, but I'm not sure it should be done here.
Under heavy network and CPU loads, I'm not sure that 8 receive buffers would be
enough, but cutting it to 4 seems unwise. Perhaps an embedded system with
limited RAM would find that change useful. I propose leaving it at 8, but add a
comment.
#define NR_PREALLOC_RECV_SKB (8)
#define RXDESC_SIZE 24
#define RXDESC_OFFSET RXDESC_SIZE
@@ -115,7 +140,7 @@ union recv_frame {
union {
struct list_head list;
struct recv_frame_hdr hdr;
- addr_t mem[RECVFRAME_HDR_ALIGN>>2];
+ uint mem[RECVFRAME_HDR_ALIGN>>2];
Does this work with 64-bit systems? I have not tested, but changing from addr_t
to uint looks wrong.
Larry
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
