On Tue, Aug 23, 2011 at 04:41:32PM +0800, Ali Bahar wrote: > You need to realize that there were 165 files which showed changes! Patches 1 and 2 are good. Then there are only 43 files left. Run git citool. Highlight all the copyright notices. Right click and select "Stage Lines for commit". That brings you down to 35 files. Since we already discussed it, the _netdev_priv() to netdev_priv() is simple. Make that a single patch. The os_free_netdev() is the same and so are the _usb_alloc_urb() and _usb_submit_urb() patches. Changing #includes can break the build but in this case it's fine to just merge all the include changes in one commit. I tested it, and it compiles ok. The rest is probably spaghetti changes like you said. There are some one liners here and there. LedControl871x() removes an unneeded NULL check. (The address of a stack variable is never NULL). There was an unused macro deleted in osdep_service.h -#define MSECS(t) (HZ * ((t) / 1000) + (HZ * ((t) % 1000)) / 1000) The changes in rtl8712_cmd.c are purely whitespace changes. It looks like the intent was to fix a bug, but the patch doesn't actually do anything. The casting changes in r8712_wep_encrypt() are wrong: - *((u32 *)crc) = cpu_to_le32(getcrc32( + *((unsigned long *)crc) = cpu_to_le32(getcrc32( payload, length)); crc is 32 bits so casting it to long will just cause memory corruption on 64 bit systems. I'm not sure what was intended. Same in r8712_wep_decrypt(). That still leaves a huge 1000 line patch... But yeah we may not have a lot of options. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
