On Mon, Aug 22, 2011 at 02:49:45PM -0500, Seth Jennings wrote: > Actually, should this be GFP_ATOMIC or GFP_NOWAIT? > GFP_ATOMIC is sort of a good default answer. GFP_NOWAIT is normally used when you want to do something really fast and if the allocation fails, you don't want to wait for it. So if memory is short, and you drop a packet? Who cares! TCP has error handling built in. Other than that, GFP_NOWAIT is used a lot in the core kernel. You could be right that GFP_NOWAIT is fine here. I don't know zcache well enough to say. How bad is it if the allocation fails? regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
