Re: [PATCH 4/9] Staging: Winbond: Convert C99 style comments in Winbond.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/17/11 12:38 AM, Gábor Stefanik wrote:
2011/8/16 Pekka Enberg<penberg@xxxxxxxxxx>:
2011/8/16 Gábor Stefanik<netrolller.3d@xxxxxxxxx>:
-
-//====================================
-// Internal variable for module
-//====================================
+/*============================================================================
+/* wb35rx.h --
+/*============================================================================
I'm pretty sure this is not an accepted kernel comment style.
What's the problem? I think it's OK for this particular patch.

The comments are not even valid C. The only reason why they do not
break is that they are immediately followed by another,
correctly-formatted (but separate) comment.
Aah,  amazing how I was able to miss that!

Akshay, I suppose you didn't compile-test the patches? Please don't
send patches like that on LKML. It's a huge waste of time for reviewers.

                                Pekka
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux