Re: [PATCHv2 01/14] staging: brcm80211: use wait queues instead of semaphores in wl_cfg80211.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 12, 2011 at 09:09:31PM +0200, Arend van Spriel wrote:
> 
> Or have people vote which version they prefer. I prefer v2.
> 

It doesn't really matter either way, but I prefer the original one.

Checkpatch.pl only cares about if statements.  This is fairly
idiomatic C.  After all we wouldn't write a while statement like:

	foo = some_func();
	while (foo) {
		frob();
		frob();
		foo = some_func();
	}

We'd just write:
	while ((foo = some_func())) {
		frob();
		frob();
	}

And do while() feels the same to me.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux