Hi Joe,
On Sunday 07 August 2011 22:15:59 Joe Perches wrote:
> On Sun, 2011-08-07 at 18:03 +0200, Marc Dietrich wrote:
> > This patch fixes coding style and adds copyright notices.
>
> Does rather more than that.
>
> > + /* VK_OEM_102 */
> > + KEY_102ND,
>
> I think this style of comment is pretty poor.
> Mixing index and comment makes for difficult reading.
so you mean the comment should be added to the same line, e.g.
KEY_102ND, /* VK_OEM_102 */
?
> > +static int nvec_status_notifier(struct notifier_block *nb,
> > + unsigned long event_type, void *data)
>
> []
>
> > - printk("unhandled msg type %ld, payload: ", event_type);
> > - for (i = 0; i < msg[1]; i++)
> > - printk("%0x ", msg[i+2]);
> > - printk("\n");
> > + printk(KERN_WARNING "unhandled msg type %ld\n", event_type);
> > + print_hex_dump(KERN_WARNING, "payload: ", DUMP_PREFIX_NONE, 16, 1,
> > + msg, msg[1] + 2, true);
>
> Not the same. I think you want:
>
> print_hex_dump(KERN_WARNING, "payload: ", DUMP_PREFIX_NONE, 16, 1,
> msg + 2, msg[1], true);
yes, the new version prints the whole packet including origin and length. I'm
fine with this, but you are right that it will change more than just "coding
style".
On the other hand, I'm a bit reluctant to create yet another patch series. Would
it be ok to fix the comment issue next time we come across this file and keep
the more detailed debug output for now?
Greetings
Marc
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
