On Sat, 13 Aug 2011, Stephen Rothwell wrote: > Hi all, > > On Sat, 13 Aug 2011 01:04:36 +0200 (CEST) Jesper Juhl <jj@xxxxxxxxxxxxx> wrote: > > > > From: Jesper Juhl <jj@xxxxxxxxxxxxx> > > Date: Sat, 13 Aug 2011 00:51:40 +0200 > > > > struct ieee80211_network is fairly large (more than half a kilobyte), > > so let's pass a pointer instead of passing the entire structure by > > value when ieee80211_is_54g() and ieee80211_is_shortslot() need to > > look at a few members. > > Also remove parentheses around the values being returned from those > > two functions - 'return' is not a function. > > Also, is there some reason that they are not "static inline bool" > functions defined directlt in ieee80211.h? > I agree to the bool return type, I should have done that. the "static inline" and defined in the header bits I didn't do because I was afraid that that was not valid in combination with EXPORT_SYMBOL(). -- Jesper Juhl <jj@xxxxxxxxxxxxx> http://www.chaosbits.net/ Don't top-post http://www.catb.org/jargon/html/T/top-post.html Plain text mails only, please. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
