On 08/09/11 19:06, Dan Carpenter wrote: > If we hit the "goto error_disable_reg" then the "st" variable is > uninitialized. Hi Dan, Have patch for this sat in iio-blue.git but quite happy to take yours instead. > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> Acked-by: Jonathan Cameron <jic23@xxxxxxxxx> > > diff --git a/drivers/staging/iio/dac/ad5504.c b/drivers/staging/iio/dac/ad5504.c > index 1915f45..88512dd 100644 > --- a/drivers/staging/iio/dac/ad5504.c > +++ b/drivers/staging/iio/dac/ad5504.c > @@ -338,7 +338,7 @@ error_free_dev: > iio_free_device(indio_dev); > error_disable_reg: > if (!IS_ERR(reg)) > - regulator_disable(st->reg); > + regulator_disable(reg); > error_put_reg: > if (!IS_ERR(reg)) > regulator_put(reg); > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
