On 08/12/2011 09:08 PM, Larry Finger wrote:
On 08/12/2011 01:59 PM, Franky Lin wrote:
If you are refering to this line
>>> + } while ((e = brcmf_deq_event(cfg_priv)));
The extra parentheses are added to fix a compiler warning:
drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c: In function
‘brcmf_event_handler’:
drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c:3576: warning: suggest
parentheses around assignment used as truth value
Does checkpatch allow that assignment in the while statement? I would expect it
to want you to
e = brcmf_deq_event(cfg_priv);
} while (e);
Larry
Yep. That is the v2 I sent. btw checkpatch did not complain on the
original patch.
Gr. AvS
--
Almost nobody dances sober, unless they happen to be insane.
-- H.P. Lovecraft --
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
