This patch series isn't broken up in the right way. [patch 1/3] removed the "extern struct class *bcm_class;" declaration from the .c and breaks the compile. [patch 2/3] adds the declaration again and fixes the compile. Breaking the compile is never allowed. The right thing is to move the change to the .c file and the .h file both in to [patch 2/2]. If you are using git citool it's pretty easy to split up changes into separate patches. Start with a no patches applied. git show <patch 1/3 hash> | patch -p1 git show <patch 2/3 hash> | patch -p1 git citool Add Bcmchar.c to the staged changes. Right click on the "extern struct class *bcm_class;" change and select "Unstage line for commit" Write the changelog and commit the 1/3 change. git citool Stage both the Bcmchar.c and the .h file. Commit 2/3. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
