Thanks for the review. I sent v2. I have a question, however...
On Mon, 01 Aug 2011 09:14:22 -0700
Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Mon, 2011-08-01 at 17:33 +0800, Leonid V. Fedorenchik wrote:
> > Fix too long lines in cx25821-audio.h and cx25821-core.c
> []
> > diff --git a/drivers/staging/cx25821/cx25821-core.c b/drivers/staging/cx25821/cx25821-core.c
> []
> > @@ -972,8 +972,8 @@ static int cx25821_dev_setup(struct cx25821_dev *dev)
> > dev->lmmio = ioremap(dev->base_io_addr, pci_resource_len(dev->pci, 0));
> >
> > if (!dev->lmmio) {
> > - CX25821_ERR
> > - ("ioremap failed, maybe increasing __VMALLOC_RESERVE in page.h\n");
> > + CX25821_ERR("ioremap failed, maybe increasing __VMALLOC_RESERVE"
> > + " in page.h\n");
>
> Please do not split formats.
What is the reason to not split formats?
I can see that in Documentation/CodingStyle in Chapter 2 it is OK to split
formats if it is not making readability worse.
So, is it for the sake of readability or is it new coding style rule for the
kernel that is not in documentation yet or something else or am I misunderstood
something?
Leonid V. Fedorenchik
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
