On 01/08/11 15:00, Manohar Vanga wrote: > Hi Martyn, > >>> Make PCI dependent functions ([alloc|free]_consistent() in >>> 'vme.c') bridge specific. By removing the dependency of the >>> VME bridge framework on PCI, this patch allows for addition of >>> non-PCI based VME bridges. >>> >> >> I like the approach, I think I agree with Dan, I'd rather see the locking >> inside the function for now. > > Just noticed that the locking that Dan was referring to and the one you agree > with in the previous patch ([PATCH 2/8] staging: vme: allow explicit assignment > of bus numbers) and not this one. Which one are you referring to here? > Whoops. Sorry, Dan's comment about the error printing, not the locking. Martyn -- Martyn Welch (Principal Software Engineer) | Registered in England and GE Intelligent Platforms | Wales (3828642) at 100 T +44(0)127322748 | Barbirolli Square, Manchester, E martyn.welch@xxxxxx | M2 3AB VAT:GB 927559189 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
