Re: [PATCH 1/2] staging: fix zcache building

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/25/2011 06:19 AM, Dan Magenheimer wrote:
From: Thadeu Lima de Souza Cascardo [mailto:cascardo@xxxxxxxxxxxxxx]
Sent: Sunday, July 24, 2011 7:14 PM
To: Nitin Gupta
Cc: Dan Magenheimer; Greg Kroah-Hartman; devel@xxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
Thadeu Lima de Souza Cascardo
Subject: [PATCH 1/2] staging: fix zcache building

zcache is only building tmem.c and not building zcache.c. To keep the
module name, zcache.c must be renamed if symbols from tmem.c are to
remain unexported.

Signed-off-by: Thadeu Lima de Souza Cascardo<cascardo@xxxxxxxxxxxxxx>

Greg --

Since a newer version of zcache.c is already in staging-next (and
hopefully soon in staging-for-linus for the 3.1 window), this
patch, which simply replaces the (older) zcache.c with identical
code with a different filename, would not apply cleanly.  Could
you advise on the best way to ensure both the newer version
and the file rename are applied... perhaps the rename must be
done manually in your git tree(s)?

Though I'm not certain of the process steps, please consider the
rename, the one liner Makefile change for the rename, and the GPL
module license addition (in patch 2/2)...

Acked-by: Dan Magenheimer<dan.magenheimer@xxxxxxxxxx>

Thanks,
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Will this fix get included in the 3.0.1 -stable release? (zcache is 'broken' (doesn't build) in Linux-3.0)

Btw, I noticed that there was another patch sent [1] to fix this issue earlier, but the original author is not mentioned in the first patch of this thread, which fixes the build failure (and the patches are almost identical I think).

[1] https://lkml.org/lkml/2011/6/22/54

Thanks,
Stratos

--
Stratos Psomadakis
<psomas@xxxxxxxxxx>

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux