On 26/07/11 16:45, Ravishankar wrote:
From: Ravishankar<ravi.shankar@xxxxxxxxxxxxxxx>
This is a patch to the c6xdigio.c file that fixes up a printk warning found by the checkpatch.pl tool
Signed-off-by: Ravishankr<ravishankarkm32@xxxxxxxxx>
---
drivers/staging/comedi/drivers/c6xdigio.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/comedi/drivers/c6xdigio.c b/drivers/staging/comedi/drivers/c6xdigio.c
index e0ac825..b0b578c 100644
--- a/drivers/staging/comedi/drivers/c6xdigio.c
+++ b/drivers/staging/comedi/drivers/c6xdigio.c
@@ -343,7 +343,7 @@ static int c6xdigio_pwmo_insn_read(struct comedi_device *dev,
struct comedi_subdevice *s,
struct comedi_insn *insn, unsigned int *data)
{
- printk("c6xdigio_pwmo_insn_read %x\n", insn->n);
+ pr_info("%s %x\n", __func__, insn->n);
return insn->n;
}
@@ -439,9 +439,9 @@ static int c6xdigio_attach(struct comedi_device *dev,
struct comedi_subdevice *s;
iobase = it->options[0];
- printk("comedi%d: c6xdigio: 0x%04lx\n", dev->minor, iobase);
+ pr_info("comedi%d: c6xdigio: 0x%04lx\n", dev->minor, iobase);
if (!request_region(iobase, C6XDIGIO_SIZE, "c6xdigio")) {
- printk("comedi%d: I/O port conflict\n", dev->minor);
+ pr_err("comedi%d: I/O port conflict\n", dev->minor);
return -EIO;
}
dev->iobase = iobase;
@@ -456,9 +456,9 @@ static int c6xdigio_attach(struct comedi_device *dev,
irq = it->options[1];
if (irq> 0)
- printk("comedi%d: irq = %u ignored\n", dev->minor, irq);
+ pr_debug("%s: %x\n", __func__, insn->n);
else if (irq == 0)
- printk("comedi%d: no irq\n", dev->minor);
+ pr_debug("%s: %x\n", __func__, insn->n);
You are doing this without any thought at all. Not only does this
replace a useful message with a completely useless one, but it also
won't even compile if DEBUG is defined. It is not confidence inspiring.
~Ryan
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
