On Tue, 2011-07-26 at 10:57 +0530, Ravishankar wrote:
> This is a patch to the c6xdigio.c file that fixes up a printk warning found by the checkpatch.pl tool
> diff --git a/drivers/staging/comedi/drivers/c6xdigio.c b/drivers/staging/comedi/drivers/c6xdigio.c
[]
> @@ -343,7 +343,7 @@ static int c6xdigio_pwmo_insn_read(struct comedi_device *dev,
[]
> - printk("c6xdigio_pwmo_insn_read %x\n", insn->n);
> + pr_info("c6xdigio_pwmo_insn_read %x\n", insn->n);
It would be good if you would convert embedded function names
to "%s", __func__. Maybe convert the bare printks to appropriate
levels as well. Perhaps:
pr_debug("%s: %x\n", __func__, insn->n);
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
