On Mon, Jul 18, 2011 at 05:34:27PM -0400, Pavel Roskin wrote: > On 07/18/2011 05:18 PM, Franky Lin wrote: > > >No, i didn't. Thank you for pointing out this. I missed it when I > >rebased my local branch. It didn't break any thing because > >brcmf_mmc_suspend is a global variable. Is it ok to keep the patch like > >this? I will prepare another patch to put it back and put the variable > >in a structure instead of using a global. > > Broken commits are bad for bisecting. "git bisect" is used to > search for a revision that introduces a bug. "git bisect" selects a > commit between the known working and the known broken revision. If > the commit selected by "git commit" suffers from additional > breakage, this could lead to wasted time and possibly to a failure > to find the commit responsible for the original problem. > This commit doesn't break anything. He explained that. brcmf_mmc_suspend is already initialized to false here because it is a static variable. Don't send a v2 of the patchset. regards, dan carpenter PS: Franky, if you already know the answer then you can just tell us. You don't need to ask for permission. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
