On Tue, 2011-07-19 at 10:25 +0530, Ravishankar wrote:
> From: Ravishankar <ravi.shankar@xxxxxxxxxxxxxxx>
> This is a patch to the adv_pci1710.c file that fixes up a printk() warning found by the checkpatch.pl tool
> Signed-off-by: Ravishankar <ravishankarkm32@xxxxxxxxx>
> ---
> KERN_CONT issue is fixed
Nope, still broken, but in a different way.
> drivers/staging/comedi/drivers/adv_pci1710.c | 20 ++++++++++----------
> 1 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/adv_pci1710.c b/drivers/staging/comedi/drivers/adv_pci1710.c
> index fd71cc6..093b9e6 100644
> --- a/drivers/staging/comedi/drivers/adv_pci1710.c
> +++ b/drivers/staging/comedi/drivers/adv_pci1710.c
> @@ -1396,14 +1396,14 @@ static int pci1710_attach(struct comedi_device *dev,
> int i;
> int board_index;
>
> - printk("comedi%d: adv_pci1710: ", dev->minor);
> + printk(KERN_CONT "comedi%d: adv_pci1710: ", dev->minor);
This should be KERN_INFO.
_All_ initial printks should have some appropriate KERN_<level>
that is not KERN_CONT (which stands for continuation, btw)
> opt_bus = it->options[0];
> opt_slot = it->options[1];
>
> ret = alloc_private(dev, sizeof(struct pci1710_private));
> if (ret < 0) {
> - printk(" - Allocation failed!\n");
> + printk(KERN_CONT " - Allocation failed!\n");
This could be:
printk(KERN_CONT "\n");
printk(KERN_ERR "Comedi%d: adv_pci1710: Allocation failed\n",
dev->minor);
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
