On Tue, 2011-07-19 at 09:22 +0530, Ravishankar wrote:
> From: Ravishankar <ravi.shankar@xxxxxxxxxxxxxxx>
> This is a patch to the adv_pci1710.c file that fixes up a printk() warning found by the checkpatch.pl tool
> Signed-off-by: Ravishankar <ravishankarkm32@xxxxxxxxx>
> ---
> KERN_INFO is replaced by KERN_ERR.
> drivers/staging/comedi/drivers/adv_pci1710.c | 20 ++++++++++----------
> 1 files changed, 10 insertions(+), 10 deletions(-)
> diff --git a/drivers/staging/comedi/drivers/adv_pci1710.c b/drivers/staging/comedi/drivers/adv_pci1710.c
> index fd71cc6..093b9e6 100644
> --- a/drivers/staging/comedi/drivers/adv_pci1710.c
> +++ b/drivers/staging/comedi/drivers/adv_pci1710.c
> @@ -1396,14 +1396,14 @@ static int pci1710_attach(struct comedi_device *dev,\
[]
> - printk("comedi%d: adv_pci1710: ", dev->minor);
> + printk(KERN_INFO "comedi%d: adv_pci1710: ", dev->minor);
[]
> if (ret < 0) {
> - printk(" - Allocation failed!\n");
> + printk(KERN_ERR " - Allocation failed!\n");
> return -ENOMEM;
> }
Ravi, (may I call you Ravi?)
you've done this several times now.
Please understand that a printk without a "\n" termination
can be continued by subsequent printks.
When that happens, you should use printk(KERN_CONT... or
pr_cont(... to continue the previous message, not give a
new error level to the continuation.
cheers, Joe
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
