On Mon, 2011-07-18 at 12:01 -0500, Larry Finger wrote: > On 07/17/2011 11:50 AM, Joe Perches wrote: > > On Sat, 2011-07-16 at 22:10 -0500, Larry Finger wrote: > >> This set of patches removes all typedefs from the driver for RTL8192E. > > As these lines touch declarations and uses of these > > typedefs, I think it'd be better to rename them > > at the same time. > > for instance these patches converted: > > typedef struct _CHANNEL_LIST -> struct CHANNEL_LIST > > I think the conversion should be to: > > typedef struct _CHANNEL_LIST -> struct channel_list > > A script that can perform these conversions: > > https://lkml.org/lkml/2009/8/14/19 > Is there a full description of how to use youur scripts? I tried both the one at > lkml.org and the one at gossamer-threads. Using a command > scripts/remove-typedef BSS_QOS bss_qos drivers/staging/rtl8192e > it gets worse. > The wrong struct is renamed. > Obviously, I'm doing something wrong. Probably not. That script worked OK on older microsoft style conversions, but it was pretty trivial. I've attached the tools I used the last time I tried something like this. The converter is detypedef.perl. Usage: perl detypedef.perl --from=from --to=to file(s)... The other files were helpers for the ath6kl project. typedefs_to_rename is a list of ath6kl specific typedefs, and doalldetypedefs.sh contains a directory reference, so you'll have to edit those if you want to use them. doalldetypedefs.sh does a git commit for each typedef converted. cheers, Joe
Attachment:
detypedef.perl
Description: Perl program
Attachment:
doalldetypedef.sh
Description: application/shellscript
AGGR_INFO AMP_ASSOC_CMD_RESP amp_assoc_cmd_resp_t APTC_TRAFFIC_RECORD aptc_traffic_record AR3K_CONFIG_INFO AR6000_BTCOEX_CONFIG ar6000_btcoex_config_t AR6000_BTCOEX_STATS ar6000_btcoex_stats_t AR6000_GET_BTCOEX_CONFIG_CMD ar6000_get_btcoex_config_cmd_t AR6000_USER_SETKEYS_INFO AR6K_ASYNC_REG_IO_BUFFER AR6K_ASYNC_REG_IO_BUFFER AR6K_DEVICE _AR6K_DEVICE AR6K_GMBOX_CTRL_REGISTERS _AR6K_GMBOX_CTRL_REGISTERS AR6K_GMBOX_INFO _AR6K_GMBOX_INFO AR6K_HCI_BRIDGE_INFO AR6K_IRQ_ENABLE_REGISTERS _AR6K_IRQ_ENABLE_REGISTERS AR6K_IRQ_PROC_REGISTERS _AR6K_IRQ_PROC_REGISTERS AR_RAW_HTC_T ar6_raw_htc AR_SOFTC_T ar6_softc AR_VIRTUAL_INTERFACE_T ATH_BT_FILTER_INSTANCE _ATHBT_FILTER_INSTANCE ATH_DEBUG_MASK_DESCRIPTION ATH_DEBUG_MODULE_DBG_INFO _ATH_DEBUG_MODULE_DBG_INFO ATH_LLC_SNAP_HDR ATH_MAC_HDR BTCOEX_A2DP_CONFIG BTCOEX_A2DP_STATS BTCOEX_ACLCOEX_CONFIG BTCOEX_ACLCOEX_STATS BTCOEX_GENERAL_STATS BTCOEX_OPTMODE_A2DP_CONFIG BTCOEX_OPTMODE_ACLCOEX_CONFIG BTCOEX_OPTMODE_SCO_CONFIG BTCOEX_PSPOLLMODE_A2DP_CONFIG BTCOEX_PSPOLLMODE_ACLCOEX_CONFIG BTCOEX_PSPOLLMODE_SCO_CONFIG BTCOEX_SCO_CONFIG BTCOEX_SCO_STATS BTCOEX_WLANSCAN_SCO_CONFIG BT_HCI_ACL_HEADER BT_HCI_COMMAND_HEADER BT_HCI_EVENT_HEADER BT_HCI_SCO_HEADER BT_PARAMS_A2DP BT_PARAMS_ACLCOEX BT_PARAMS_SCO BUFFER_PROC_LIST _BUFFER_PROC_LIST BUS_REQUEST bus_request COMMON_CREDIT_STATE_INFO _COMMON_CREDIT_STATE_INFO COUNTRY_CODE_TO_ENUM_RD DBGLOG_MODULE_CONFIG ar6000_dbglog_module_config_s DEV_SCATTER_DMA_VIRTUAL_INFO _DEV_SCATTER_DMA_VIRTUAL_INFO EPPING_CONT_RX_PARAMS EPPING_HEADER FLOW_SPEC flow_spec_t GMBOX_PROTO_HCI_UART HCI_ACL_DATA_PKT hci_acl_data_pkt_t HCI_CMD_CREATE_LOGICAL_LINK hci_cmd_create_logical_link_t HCI_CMD_DISCONNECT_LOGICAL_LINK hci_cmd_disconnect_logical_link_t HCI_CMD_DISCONNECT_PHY_LINK hci_cmd_disconnect_phy_link_t HCI_CMD_ENHANCED_FLUSH hci_cmd_enhanced_flush_t HCI_CMD_FLOW_SPEC_MODIFY hci_cmd_flow_spec_modify_t HCI_CMD_LOGICAL_LINK_CANCEL hci_cmd_logical_link_cancel_t HCI_CMD_PHY_LINK hci_cmd_phy_link_t HCI_CMD_PKT hci_cmd_pkt_t HCI_CMD_READ_LOCAL_AMP_ASSOC hci_cmd_read_local_amp_assoc_t HCI_CMD_SHORT_RANGE_MODE hci_cmd_srm_t HCI_CMD_WRITE_FLOW_CONTROL hci_cmd_write_flow_control_t HCI_CMD_WRITE_LINK_SUPERVISION_TIMEOUT hci_cmd_write_link_supervision_timeout_t HCI_CMD_WRITE_LOCATION_DATA hci_cmd_write_location_data_t HCI_CMD_WRITE_REM_AMP_ASSOC hci_cmd_write_rem_amp_assoc_t HCI_CMD_WRITE_TIMEOUT hci_cmd_write_timeout_t HCI_EVENT_AMP_STATUS_CHANGE hci_event_amp_status_change_t HCI_EVENT_CHAN_SELECT hci_event_chan_select_t HCI_EVENT_CMD_COMPLETE hci_event_cmd_complete_t HCI_EVENT_CMD_STATUS hci_event_cmd_status_t HCI_EVENT_DATA_BUF_OVERFLOW hci_data_buf_overflow_t HCI_EVENT_DISCONNECT_LOGICAL_LINK_EVENT hci_event_disconnect_logical_link_event_t HCI_EVENT_DISCONNECT_PHY_LINK_COMPLETE hci_event_disconnect_phy_link_complete_t HCI_EVENT_ENHANCED_FLUSH_COMPLT hci_enhanced_flush_complt_t HCI_EVENT_HW_ERR hci_event_hw_err_t HCI_EVENT_LOGICAL_LINK_COMPLETE_EVENT hci_event_logical_link_complete_event_t HCI_EVENT_LOOPBACK_CMD hci_loopback_cmd_t HCI_EVENT_NUM_COMPL_DATA_BLKS hci_event_num_of_compl_data_blks_t HCI_EVENT_PHY_LINK_COMPLETE hci_event_phy_link_complete_event_t HCI_EVENT_PHY_LINK_LOSS_EARLY_WARNING hci_event_physical_link_loss_early_warning_t HCI_EVENT_PHY_LINK_RECOVERY hci_event_physical_link_recovery_t HCI_EVENT_PKT hci_event_pkt_t HCI_EVENT_SRM_COMPL hci_srm_cmpl_t HCI_TRANSPORT_CALLBACKS HCI_TRANSPORT_CONFIG_INFO _HCI_TRANSPORT_CONFIG_INFO HCI_TRANSPORT_MISC_HANDLES HCI_TRANSPORT_PROPERTIES HIF_DEVICE_IRQ_YIELD_PARAMS HIF_DEVICE_MBOX_INFO HIF_DEVICE_OS_DEVICE_INFO HIF_DEVICE_SCATTER_SUPPORT_INFO _HIF_DEVICE_SCATTER_SUPPORT_INFO HIF_MBOX_PROPERTIES HIF_PENDING_EVENTS_INFO _HIF_PENDING_EVENTS_INFO HIF_SCATTER_ITEM _HIF_SCATTER_ITEM HIF_SCATTER_REQ _HIF_SCATTER_REQ HIF_SCATTER_REQ_PRIV _HIF_SCATTER_REQ_PRIV HTC_BUNDLED_LOOKAHEAD_REPORT HTC_CONNECT_SERVICE_MSG HTC_CONNECT_SERVICE_RESPONSE_MSG HTC_CONTROL_BUFFER HTC_CONTROL_BUFFER HTC_CREDIT_REPORT HTC_ENDPOINT_CREDIT_DIST _HTC_ENDPOINT_CREDIT_DIST HTC_ENDPOINT _HTC_ENDPOINT HTC_ENDPOINT_STATS _HTC_ENDPOINT_STATS HTC_EP_CALLBACKS _HTC_EP_CALLBACKS HTC_FRAME_HDR _HTC_FRAME_HDR HTC_INIT_INFO _HTC_INIT_INFO HTC_LOOKAHEAD_REPORT HTC_PACKET _HTC_PACKET HTC_PACKET_QUEUE _HTC_PACKET_QUEUE HTC_READY_EX_MSG HTC_READY_MSG HTC_RECORD_HDR HTC_RX_PACKET_INFO _HTC_RX_PACKET_INFO HTC_SERVICE_CONNECT_REQ _HTC_SERVICE_CONNECT_REQ HTC_SERVICE_CONNECT_RESP _HTC_SERVICE_CONNECT_RESP HTC_SETUP_COMPLETE_EX_MSG HTC_SETUP_COMPLETE_MSG HTC_TARGET _HTC_TARGET HTC_TX_PACKET_INFO _HTC_TX_PACKET_INFO HTC_UNKNOWN_MSG INFO_STATUS_HDL status_hdl_t INI_DSET_REG_OVERRIDE LINK_SUPERVISION_TIMEOUT_INFO link_supervision_timeout_read_t LL_CANCEL_RESP ll_cancel_resp_t LOCAL_AMP_INFO local_amp_info_resp_t LOCATION_DATA_CFG location_data_cfg_t MAC_FILTER MAC_FILTER_LIST OSBUF_HOLD_Q OSDRV_CALLBACKS osdrv_callbacks PACKET_LOG pkt_log_t READ_DATA_BLK_SIZE_INFO read_data_blk_size_t READ_FLWCTRL_INFO read_flow_ctrl_mode_t READ_LOCAL_VER_INFO read_local_ver_info_t READ_LOC_INFO read_loc_info_t REG_DMN_FREQ_BAND RegDmnFreqBand REG_DMN_PAIR_MAPPING reg_dmn_pair_mapping REG_DOMAIN regDomain RXTID RXTID_STATS SQ_THRESHOLD_PARAMS sq_threshold_params_s ST_PS_DATA_FORMAT ST_PS_DATA_FORMAT ST_READ_STATUS ST_READ_STATUS TARGET_REGISTER_TABLE targetdef_s TARGET_STATS_CMD targetStats_cmd_t TARGET_STATS targetStats_t TCMD_CONT_RX TCMD_CONT_TX TCMD_PM TIMEOUT_INFO timeout_read_t USER_RSSI_CPENSATION user_rssi_compensation_t USER_RSSI_PARAMS user_rssi_params_t USER_RSSI_THOLD user_rssi_thold_t WHAL_PARAMCMD WHAL_SETCABTO_PARAM WINDOW_SNAPSHOT WMI_ACM_REJECT_EVENT WMI_ADD_BAD_AP_CMD WMI_ADDBA_REQ_CMD WMI_ADDBA_REQ_EVENT WMI_ADDBA_RESP_EVENT WMI_ADD_CIPHER_KEY_CMD WMI_ADD_KRK_CMD WMI_ADD_WOW_PATTERN_CMD WMI_ALLOW_AGGR_CMD WMI_AP_ACL WMI_AP_ACL_MAC_CMD WMI_AP_ACL_POLICY_CMD WMI_AP_CONN_INACT_CMD WMI_AP_HIDDEN_SSID_CMD WMI_APLIST_EVENT WMI_AP_MODE_STAT WMI_AP_PROT_SCAN_TIME_CMD WMI_AP_PS_CMD WMI_AP_SET_11BG_RATESET_CMD WMI_AP_SET_COUNTRY_CMD WMI_AP_SET_DTIM_CMD WMI_AP_SET_MLME_CMD WMI_AP_SET_NUM_STA_CMD WMI_AP_SET_PVB_CMD WMI_BEACON_INT_CMD WMI_BIT_RATE_CMD WMI_BIT_RATE_REPLY WMI_BMISS_TIME_CMD WMI_BSS_BIAS WMI_BSS_BIAS_INFO WMI_BSS_FILTER_CMD WMI_BSS_INFO_HDR WMI_BSS_ROAM_INFO WMI_BTCOEX_CONFIG_EVENT WMI_BTCOEX_STATS_EVENT WMI_CAC_EVENT WMI_CHANNEL_CHANGE_EVENT WMI_CHANNEL_LIST_REPLY WMI_CHANNEL_PARAMS_CMD WMI_CMD_ERROR_EVENT WMI_CMD_HDR WMI_CONNECT_CMD WMI_CONNECT_EVENT WMI_CREATE_PSTREAM_CMD WMI_CRE_PRIORITY_STREAM_REPLY WMI_DATA_HDR WMI_DATA_SYNC_BUFS _WMI_DATA_SYNC_BUFS WMI_DELBA_EVENT WMI_DELBA_REQ_CMD WMI_DELETE_BAD_AP_CMD WMI_DELETE_CIPHER_KEY_CMD WMI_DELETE_PSTREAM_CMD WMI_DEL_PRIORITY_STREAM_REPLY WMI_DEL_WOW_PATTERN_CMD WMI_DISCONNECT_EVENT WMI_DISC_TIMEOUT_CMD WMI_ENABLE_RM_CMD WMI_GET_BTCOEX_CONFIG_CMD WMI_GET_KEEPALIVE_CMD WMI_GET_WOW_LIST_CMD WMI_GET_WOW_LIST_REPLY WMI_HCI_CMD WMI_HCI_EVENT WMI_IBSS_PM_CAPS_CMD WMI_LISTEN_INT_CMD WMI_LOWRSSI_SCAN_PARAMS WMI_LOWRSSI_SCAN_PARAMS WMI_LQ_THRESHOLD_EVENT WMI_LQ_THRESHOLD_PARAMS_CMD WMI_LQ_THRESHOLD_PARAMS WMI_MCAST_FILTER_CMD WMI_NEIGHBOR_INFO WMI_NEIGHBOR_REPORT_EVENT WMI_OPT_RX_INFO_HDR WMI_OPT_TX_FRAME_CMD WMI_PEER_NODE_EVENT WMI_PER_STA_STAT WMI_PMKID WMI_PMKID_LIST_REPLY WMI_POWER_MODE_CMD WMI_POWER_PARAMS_CMD WMI_POWERSAVE_TIMERS_POLICY_CMD WMI_PROBED_SSID_CMD WMI_PSPOLL_EVENT WMI_PSTREAM_TIMEOUT_EVENT WMI_RECONNECT_CMD WMI_REG_DOMAIN_EVENT WMI_REPORT_SLEEP_STATE_EVENT WMI_RSSI_THRESHOLD_EVENT WMI_RSSI_THRESHOLD_PARAMS_CMD WMI_RSSI_THRESHOLD_PARAMS WMI_RX_FRAME_FORMAT_CMD WMI_SCAN_COMPLETE_EVENT WMI_SCAN_PARAMS_CMD WMI_SET_ACCESS_PARAMS_CMD WMI_SET_ADHOC_BSSID_CMD WMI_SET_AKMP_PARAMS_CMD WMI_SET_APPIE_CMD WMI_SET_ASSOC_INFO_CMD WMI_SET_AUTH_MODE_CMD WMI_SET_BTCOEX_A2DP_CONFIG_CMD WMI_SET_BTCOEX_ACLCOEX_CONFIG_CMD WMI_SET_BTCOEX_BTINQUIRY_PAGE_CONFIG_CMD WMI_SET_BTCOEX_BT_OPERATING_STATUS_CMD WMI_SET_BTCOEX_COLOCATED_BT_DEV_CMD WMI_SET_BTCOEX_DEBUG_CMD WMI_SET_BTCOEX_FE_ANT_CMD WMI_SET_BTCOEX_SCO_CONFIG_CMD WMI_SET_BT_PARAMS_CMD WMI_SET_BT_STATUS_CMD WMI_SET_BT_WLAN_CONN_PRECEDENCE WMI_SET_HB_CHALLENGE_RESP_PARAMS_CMD WMI_SET_HOST_SLEEP_MODE_CMD WMI_SET_HT_CAP_CMD WMI_SET_HT_OP_CMD WMI_SET_IP_CMD WMI_SET_KEEPALIVE_CMD WMI_SET_LPREAMBLE_CMD WMI_SET_MAC_ADDRESS_CMD WMI_SET_MAX_OFFHOME_DURATION_CMD WMI_SET_MAX_SP_LEN_CMD WMI_SET_MCAST_FILTER_CMD WMI_SET_OPT_MODE_CMD WMI_SET_PARAMS_CMD WMI_SET_PARAMS_REPLY WMI_SET_PMK_CMD WMI_SET_PMKID_CMD WMI_SET_PMKID_LIST_CMD WMI_SET_QOS_SUPP_CMD WMI_SET_RATE_POLICY_CMD WMI_SET_REASSOC_MODE_CMD WMI_SET_RETRY_LIMITS_CMD WMI_SET_ROAM_CTRL_CMD WMI_SET_RTS_CMD WMI_SET_TARGET_EVENT_REPORT_CMD WMI_SET_THIN_MODE_CMD WMI_SET_TKIP_COUNTERMEASURES_CMD WMI_SET_TX_SELECT_RATES_CMD WMI_SET_TX_SGI_PARAM_CMD WMI_SET_VOICE_PKT_SIZE_CMD WMI_SET_WMM_CMD WMI_SET_WMM_TXOP_CMD WMI_SET_WOW_MODE_CMD WMI_SNR_THRESHOLD_EVENT WMI_SNR_THRESHOLD_PARAMS_CMD WMI_SNR_THRESHOLD_PARAMS WMI_START_SCAN_CMD WMI_SYNC_CMD WMI_TARGET_ERROR_REPORT_BITMASK WMI_TARGET_ERROR_REPORT_EVENT WMI_TARGET_ROAM_DATA WMI_TARGET_ROAM_TBL WMI_TARGET_ROAM_TIME WMI_TARGET_STATS WMI_THIN_CONFIG_CMD WMI_THIN_CONFIG_DECRYPT_ERR WMI_THIN_CONFIG_RX_FILTER_RULES WMI_THIN_CONFIG_TXCOMPLETE WMI_THIN_CONFIG_TX_MAC_RULES WMI_THIN_GET_MIB_CMD WMI_THIN_JOIN_CMD WMI_THIN_JOIN_EVENT WMI_THIN_MIB_BEACON_FILTER WMI_THIN_MIB_BEACON_FILTER_TABLE WMI_THIN_MIB_BEACON_FILTER_TABLE_HEADER WMI_THIN_MIB_BEACON_FILTER_TABLE_OUI WMI_THIN_MIB_BEACON_LOST_COUNT WMI_THIN_MIB_CTS_TO_SELF WMI_THIN_MIB_HT_2ND_BEACON WMI_THIN_MIB_HT_BLOCK_ACK WMI_THIN_MIB_HT_CAP WMI_THIN_MIB_HT_OP WMI_THIN_MIB_PREAMBLE WMI_THIN_MIB_RSSI_THRESHOLD WMI_THIN_MIB_RTS_THRESHOLD WMI_THIN_MIB_RXFRAME_FILTER WMI_THIN_MIB_RX_LIFE_TIME WMI_THIN_MIB_SLOT_TIME WMI_THIN_MIB_STA_MAC WMI_THIN_MIB_TEMPLATE_FRAME WMI_THIN_POST_ASSOC_CMD WMI_THIN_SET_MIB_CMD WMI_TKIP_MICERR_EVENT WMI_TX_COMPLETE_EVENT WMI_TX_RETRY_ERR_EVENT WMI_WAPIREKEY_EVENT WMI_WLAN_VERSION_EVENT WMIX_CMD_HDR WMIX_DBGLOG_CFG_MODULE_CMD WMIX_DSETCLOSE_EVENT WMIX_DSETDATA_REPLY_CMD WMIX_DSETDATAREQ_EVENT WMIX_DSETOPEN_REPLY_CMD WMIX_DSETOPENREQ_EVENT WMIX_GPIO_DATA_EVENT WMIX_GPIO_INTR_ACK_CMD WMIX_GPIO_INTR_EVENT WMIX_GPIO_OUTPUT_SET_CMD WMIX_GPIO_REGISTER_GET_CMD WMIX_GPIO_REGISTER_SET_CMD WMIX_HB_CHALLENGE_RESP_CMD WMIX_PROF_ADDR_SET_CMD WMIX_PROF_CFG_CMD WMIX_PROF_COUNT_EVENT WMM_TSPEC_IE wmm_tspec_ie_t WOW_CONFIG_DSET wow_config_dset WOW_FILTER WOW_FILTER_LIST WRITE_REMOTE_AMP_ASSOC_INFO write_remote_amp_assoc_t
Attachment:
find_typedef_struct.perl
Description: Perl program
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
