Re: [PATCH 1/8 V2] staging: rtl8192e: Remove typedefs - Part I

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2011-07-17 at 22:19 -0500, Larry Finger wrote:
> As part of the cleanup of the driver, typedef statements are removed.

Hey Larry.

Please separate the changes by specific struct.
What you've done makes it a bit hard to verify.

For instance:

> @@ -117,15 +116,15 @@ void Dot11d_Reset(struct rtllib_device *ieee)
>  void Dot11d_UpdateCountryIe(struct rtllib_device *dev, u8 *pTaddr,
>  	                    u16 CoutryIeLen, u8* pCoutryIe)
>  {
> -	PRT_DOT11D_INFO pDot11dInfo = GET_DOT11D_INFO(dev);
> +	struct rt_dot11d_info *pDot11dInfo = GET_DOT11D_INFO(dev);
>  	u8 i, j, NumTriples, MaxChnlNum;
> -	PCHNL_TXPOWER_TRIPLE pTriple;
> +	struct chnl_txpower_triple *pTriple;
[]
> @@ -146,7 +145,7 @@ void Dot11d_UpdateCountryIe(struct rtllib_device *dev, u8 *pTaddr,
>  			MaxChnlNum = pTriple->FirstChnl + j;
>  		}
>  
> -		pTriple = (PCHNL_TXPOWER_TRIPLE)((u8*)pTriple + 3);
> +		pTriple = pTriple + 3;

Not the same code.

Sorry, I'm not going to check the rest of the code
until this sort of thing is a bit easier to read.

cheers, Joe

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux