Hi, On Fri, Jul 15, 2011 at 07:29, Franky Lin <frankyl@xxxxxxxxxxxx> wrote: > From: Roland Vossen <rvossen@xxxxxxxxxxxx> > > Softmac related code cleanup. Typedefs are undesirable according to the > CodingStyle document. > > Signed-off-by: Roland Vossen <rvossen@xxxxxxxxxxxx> > Reviewed-by: Arend van Spriel <arend@xxxxxxxxxxxx> > --- > diff --git a/drivers/staging/brcm80211/brcmsmac/aiutils.c b/drivers/staging/brcm80211/brcmsmac/aiutils.c > index a25901e..5a5fc4b 100644 > --- a/drivers/staging/brcm80211/brcmsmac/aiutils.c > +++ b/drivers/staging/brcm80211/brcmsmac/aiutils.c > @@ -1279,9 +1279,9 @@ ai_register_intr_callback(struct si_pub *sih, void *intrsoff_fn, > > sii = SI_INFO(sih); > sii->intr_arg = intr_arg; > - sii->intrsoff_fn = (si_intrsoff_t) intrsoff_fn; > - sii->intrsrestore_fn = (si_intrsrestore_t) intrsrestore_fn; > - sii->intrsenabled_fn = (si_intrsenabled_t) intrsenabled_fn; > + sii->intrsoff_fn = (u32 (*)(void *)) intrsoff_fn; > + sii->intrsrestore_fn = (void (*) (void *, u32)) intrsrestore_fn; > + sii->intrsenabled_fn = (bool (*)(void *)) intrsenabled_fn; > /* save current core id. when this function called, the current core > * must be the core which provides driver functions(il, et, wl, etc.) > */ Are these casts necessary - as in could better types be chosen for these function pointers and the underlying functions themselves? I see the same issue in patches 6 - 10. (my apologies if you've addressed this later) Thanks, -- Julian Calaby Email: julian.calaby@xxxxxxxxx Profile: http://www.google.com/profiles/julian.calaby/ .Plan: http://sites.google.com/site/juliancalaby/ _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
