Re: [PATCH 1/3] Staging: comedi: fix warning issue in daqboard2000.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 14, 2011 at 11:32:13AM +0530, Ravishankar wrote:
>     2. The initialization done so far is:
> -        a. program the FPGA (windows code sans a lot of error messages)
> +	a.program the FPGA(windows code sans a lot of error messages)
          ^
Space needed here.


>  
> -        Word0:
> -          +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> -          ! | | | ! | | | ! | | | ! | | | !
> -          +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> +	Word0:
> +	  +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> +	  !|||!|||!|||!|||!
> +	  +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+

No.  The original comment is a diagram and you have destroyed it
completely.

You are writing all these patches to do the minimum needed to make
check patch happy.  Check patch is not a human being.  Do not write
code to please check patch, because it feels no sadness or happiness.

You have made yourself into a servant of a shell script.  Have some
dignity.

regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux