Re: [PATCH 1/6] staging: rtl8192e: Remove code dependent on RTL8190P

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 12, 2011 at 08:24:08PM -0500, Larry Finger wrote:
> On 07/12/2011 04:26 PM, Dan Carpenter wrote:
> >>@@ -1712,25 +1602,6 @@ void rtl8192_query_rxphystatus(
> >>  	{
> >>
> >>  		u8 report;
> >>-#ifdef RTL8190P
> >>-		u8 tmp_pwdb;
> >>-		char cck_adc_pwdb[4];
> >>-#endif
> >>-		priv->stats.numqry_phystatusCCK++;
> >                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> >
> >Did you intend to remove that?
> 
> No, I fat-fingered that line. I'll fix with V2.
>

I've sort of decided that I hate re-reviewing version 2 of
patchsets.  If you send a v2 does that mean you have to redo a lot
of other patches or is it just this one?  The bug here is not a very
serious one, and I would be fine with just a fixup patch applied on
top of the set.

regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux