On 07/13/2011 07:31 AM, Joe Perches wrote:
> On Wed, 2011-07-13 at 04:36 +0300, Kalle Valo wrote:
>> Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxxxx>
>> drivers/net/wireless/ath/ath6kl/txrx.c | 1471 ++++++++++++++++++++++++++++++++
> []
>> +int ath6kl_control_tx(void *devt, struct sk_buff *skb,
>> + enum htc_endpoint_id eid)
>> +{
> []
>> + ath6kl_dbg(ATH6KL_DBG_WLAN_TX,
>> + "%s: skb=0x%lx, len=0x%x eid =%d\n", __func__,
>> + (unsigned long)skb, skb->len, eid);
>
>
> This style of casting a pointer to an unsigned long is used
> unnecessarily quite often.
>
> I think it's more intelligible to use %p without the case.
> Also, hex length is often not as readable as decimal.
>
> ath6kl_dbg(ATH6KL_DBG_WLAN_TX, "%s: skb=%p, len=%u eid=%d\n",
> __func__, skb, skb->len, eid);
I agree. We already had a task in the todo list about this.
Kalle
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
