On Mon, Jul 11, 2011 at 12:49:14PM +0530, Ravishankar wrote:
> From: Ravishankar <ravi.shankar@xxxxxxxxxxxxxxx>
>
> This is a patch to the pcl818.c file that fixes up a printk warning found by the checkpatch.pl tool
>
> Signed-off-by: Ravishankar <ravishankarkm32@xxxxxxxxx>
> ---
> drivers/staging/comedi/drivers/pcl818.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c
> index ae097b3..21f1cc9 100644
> --- a/drivers/staging/comedi/drivers/pcl818.c
> +++ b/drivers/staging/comedi/drivers/pcl818.c
> @@ -1447,7 +1447,7 @@ static int ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
> struct comedi_cmd *cmd = &s->async->cmd;
> int retval;
>
> - printk("pcl818_ai_cmd()\n");
> + printk(KERN_INFO "pcl818_ai_cmd()\n");
KERN_INFO is too high a level here. Ideally this would just be
removed. Possibly made into a dev_dbg().
The same is true for some other printks in this series.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
