On Mon, 2011-07-11 at 11:30 +0530, Ravishankar wrote:
> This is a patch to the pcl818.c file that fixes up a brace warning found by the checkpatch.pl tool
> diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c
[]
> @@ -1301,11 +1301,10 @@ static void setup_channel_list(struct comedi_device *dev,
> */
> static int check_single_ended(unsigned int port)
> {
> - if (inb(port + PCL818_STATUS) & 0x20) {
> + if (inb(port + PCL818_STATUS) & 0x20)
> return 1;
> - } else {
> + else
> return 0;
> - }
> }
I'd prefer this become:
static bool check_single_ended()
{
if (...)
return true;
return false;
}
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
