Re: [PATCH] Fix a miswriting in ext_sd_send_cmd_get_rsp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2011年07月11日 10:13, 王炜 wrote:
From: wwang<wei_wang@xxxxxxxxxxxxxx>

cppcheck reported: [staging/rts_pstor/sd.c:3730] ->  [staging/rts_pstor/sd.c:3726]: (style) Found duplicate if expressions.
It's a miswriting, and the second if expression should be "(rsp_type == SD_RSP_TYPE_R0)"

Signed-off-by: wwang<wei_wang@xxxxxxxxxxxxxx>
---
  drivers/staging/rts_pstor/sd.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging/rts_pstor/sd.c
index e4b3891..8db14dd 100644
--- a/drivers/staging/rts_pstor/sd.c
+++ b/drivers/staging/rts_pstor/sd.c
@@ -3747,7 +3747,7 @@ RTY_SEND_CMD:
  				if ((ptr[3]&  0x1E) != 0x04) {
  					TRACE_RET(chip, STATUS_FAIL);
  				}
-			} else if (rsp_type == SD_RSP_TYPE_R2) {
+			} else if (rsp_type == SD_RSP_TYPE_R0) {
  				if ((ptr[3]&  0x1E) != 0x03) {
  					TRACE_RET(chip, STATUS_FAIL);
  				}

Dear all:

Sorry to bother, please ignore this mail, I will modify the log resend again.

    Best regards,
    wwang

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux