----- Ursprüngliche Mail ---- > Von: Greg KH <greg@xxxxxxxxx> > An: markpearson_de@xxxxxxxx > CC: abbotti@xxxxxxxxx; fmhess@xxxxxxxxxxxxxxxxxxxxx; >devel@xxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Gesendet: Sonntag, den 10. Juli 2011, 20:26:34 Uhr > Betreff: Re: [PATCH] Staging: comedi: Fixing style issues > > On Sun, Jul 10, 2011 at 08:12:46PM +0200, markpearson_de@xxxxxxxx wrote: > > From: Mark Pearson <markpearson_de@xxxxxxxx> > > > > comedi_fops.c : Warning that externs should be avoided in .c files. > > A forward function decleration was declared extern > > although it was only used internally. Changed > > decleration to static. > > comedi.h : Fixed warning that storage class should be a the > > begining of declerations. > > > > Lindent ran on both files. > > > > Ignore previous patch - forgot to add signed off by. > > Care to break this up into a set of "only do one thing per patch" > series? That way it's reviewable. > > Also, running Lindent is usually a very bad idea on files that have been > around for a while now. It causes a lot of unneeded churn, please just > make the minor changes needed to be checkpatch.pl clean by hand. > > thanks, > > greg k-h > No problem Greg. I've submitted the patches for the two files again as a one-thing-per-patch and left out the Lindent. Thanks for the feedback. Cheers, Mark. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
