[smatch stuff] re: gma500: continue abstracting platform specific code

[Dan Carpenter <error27@xxxxxxxxx>]

Hi Alan,

Smatch complains about 6a7afe3acc4b "gma500: continue abstracting
platform specific code"

drivers/staging/gma500/psb_intel_lvds.c +579 psb_intel_lvds_set_property(7)
	warn: variable dereferenced before check 'encoder'

--- a/drivers/staging/gma500/psb_intel_lvds.c
+++ b/drivers/staging/gma500/psb_intel_lvds.c
@@ -575,11 +575,12 @@ int psb_intel_lvds_set_property(struct drm_connector *connector,
                                       struct drm_property *property,
                                       uint64_t value)
 {
-       struct drm_encoder *pEncoder = connector->encoder;
+       struct drm_encoder *encoder = connector->encoder;
+       struct drm_psb_private *dev_priv = encoder->dev->dev_private;
                                           ^^^^^^^^^^^^
dereference encoder here.

-       if (!strcmp(property->name, "scaling mode") && pEncoder) {
+       if (!strcmp(property->name, "scaling mode") && encoder) {
                                                       ^^^^^^^
checking for NULL here.

                struct psb_intel_crtc *pPsbCrtc =
-                                       to_psb_intel_crtc(pEncoder->crtc);
+                                       to_psb_intel_crtc(encoder->crtc);

regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel