On Wed, Jul 06, 2011 at 02:37:26PM -0700, David Brown wrote: > On Wed, Jul 06 2011, Greg KH wrote: > > > On Wed, Jul 06, 2011 at 09:45:08PM +0530, Prashant Shah wrote: > >> Hi, > >> > >> > So that would be one patch for fixing extra braces, one for extra > >> > spaces, and so on. That makes it easier to review. > >> > >> Ok I will redo them. > >> > >> On Wed, Jul 6, 2011 at 9:27 PM, Greg KH <gregkh@xxxxxxx> wrote: > >> > On Wed, Jul 06, 2011 at 01:19:34PM +0530, Prashant P. Shah wrote: > >> > Also, did you successfully build this code before and after your > >> > changes? > >> > >> I tried but the code does not build because of #include <mach/board.h> > >> in the msm_fb.c file. I dont know how to fix that. > > > > I say let's just delete this whole directory as if it doesn't build, no > > one is using it, and no one has tried to clean it up since it was > > originally added. > > > > Stepan or David or Abhijeet or Daniel, any objection to just deleting > > drivers/staging/msm/ at this point in time for the 3.1 kernel release? > > You haven't sent any patches to me to clean this code up since the > > original patch, way over a year ago. > > I have none. The non-staging driver has been getting updates, and I > asked the author if it was OK to remove the staging one. I believe the > real driver supports everything the staging one did. > > Should I generate a (large) patch, or is it easier for you to just > remove the tree? I'll just remove it, it's easier that way. Can I add your "Acked-by:" to the patch? thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
