Re: [PATCH 3/3] Staging: comedi: fix warning: line over 80 characters issue in usbduxfast.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 06, 2011 at 01:56:50PM +0530, Ravishankar wrote:
> -	ret = request_firmware_nowait(THIS_MODULE,
> -				      FW_ACTION_HOTPLUG,
> -				      "usbduxfast_firmware.bin",
> -				      &udev->dev,
> -				      GFP_KERNEL,
> -				      usbduxfastsub + index,
> -				      usbduxfast_firmware_request_complete_handler);
> +	ret =
> +	request_firmware_nowait(THIS_MODULE,
> +				FW_ACTION_HOTPLUG,
> +				"usbduxfast_firmware.bin",
> +				&udev->dev,
> +				GFP_KERNEL,
> +				usbduxfastsub + index,
> +				usbduxfast_firmware_request_complete_handler);
> +

No.  Don't do this.  The "usbduxfast_firmware_request_complete_handler"
variable name is too long.  Rename it something shorter.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux