On Wed, Jul 06, 2011 at 01:56:50PM +0530, Ravishankar wrote: > - ret = request_firmware_nowait(THIS_MODULE, > - FW_ACTION_HOTPLUG, > - "usbduxfast_firmware.bin", > - &udev->dev, > - GFP_KERNEL, > - usbduxfastsub + index, > - usbduxfast_firmware_request_complete_handler); > + ret = > + request_firmware_nowait(THIS_MODULE, > + FW_ACTION_HOTPLUG, > + "usbduxfast_firmware.bin", > + &udev->dev, > + GFP_KERNEL, > + usbduxfastsub + index, > + usbduxfast_firmware_request_complete_handler); > + No. Don't do this. The "usbduxfast_firmware_request_complete_handler" variable name is too long. Rename it something shorter. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
