> -----Original Message----- > From: Greg KH [mailto:greg@xxxxxxxxx] > Sent: Tuesday, July 05, 2011 12:06 PM > To: KY Srinivasan > Cc: gregkh@xxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > devel@xxxxxxxxxxxxxxxxxxxxxx; virtualization@xxxxxxxxxxxxxx; Haiyang Zhang; Hank > Janssen > Subject: Re: [PATCH 15/77] Staging: hv: blkvsc: Add the appropriate > MODULE_ALIAS() line > > On Thu, Jun 16, 2011 at 01:16:48PM -0700, K. Y. Srinivasan wrote: > > Add the appropriate MODULE_ALIAS() line to support auto-loading. > > > > Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx> > > Signed-off-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx> > > Signed-off-by: Hank Janssen <hjanssen@xxxxxxxxxxxxx> > > --- > > drivers/staging/hv/blkvsc_drv.c | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/staging/hv/blkvsc_drv.c b/drivers/staging/hv/blkvsc_drv.c > > index 5842db8..9496abe 100644 > > --- a/drivers/staging/hv/blkvsc_drv.c > > +++ b/drivers/staging/hv/blkvsc_drv.c > > @@ -1027,5 +1027,6 @@ static void __exit blkvsc_exit(void) > > MODULE_LICENSE("GPL"); > > MODULE_VERSION(HV_DRV_VERSION); > > MODULE_DESCRIPTION("Microsoft Hyper-V virtual block driver"); > > +MODULE_ALIAS("vmbus:hv_block"); > > No, these should be automagically generated with the MODULE_DEVICE_ID() > macro that you use in the module with the GUID there, instead of this. I think you mean MODULE_DEVICE_TABLE()? I actually went down that path first adding code to file2alias.c for parsing the vmbus ID table. Given that this approach would make it impossible to support auto-loading of these drivers on many of the released kernels, I chose to go with the MODULE_ALIAS() macro that did not need any changes outside our drivers. In both methods, the formatting of the name is bus specific since I would be writing the code to parse the table in file2alias.c. Granted, I have been quite unimaginative in my alias names, but I thought they were reasonably descriptive. If at all possible, for the reasons listed above, I would prefer to use the MODULE_ALIAS() macro (I could embed all or part of the guid in the alias). Let me know. Regards, K. Y _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
