Re: [PATCH v2 00/21] staging: brcm80211: mostly fullmac cleanup patches

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/05/2011 10:38 PM, Rafał Miłecki wrote:
2011/7/5 Arend van Spriel<arend@xxxxxxxxxxxx>:
(...)
  staging: brcm80211: removed brcmf_sdioh_interrupt_pending()
  staging: brcm80211: removed brcmf_sdioh_reset()
  staging: brcm80211: removed brcmf_sdioh_start() and
    brcmf_sdioh_stop()
Arend, can you say something more about what does happen here?

You drop some functions that were empty, but I guess there were here
for some reason. Did you discover in development process that things
like start/stop/reset is not needed? Or did you put place for
something that appeared to be not available on SDIO?

Shouldn't we keep it here and just implement lacking code?

From what I know this code was intended platform/os independent. In the open-source linux driver it was not needed as it relies on mmc_core/sdhci/etc. modules. I am more focused on softmac driver so the fullmac guys may want to correct my statements made here.

Gr. AvS

--
Almost nobody dances sober, unless they happen to be insane.
-- H.P. Lovecraft --


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux