Re: [PATCH] gma500: fix compiler warnings and format string

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 3 Jul 2011, Alan Cox wrote:

> On Sun, 3 Jul 2011 09:16:13 +0200 (CEST)
> Jesper Juhl <jj@xxxxxxxxxxxxx> wrote:
> 
> > This patch fixes these compiler warnings:
> > 
> >   CC      drivers/staging/gma500/psb_gtt.o
> > drivers/staging/gma500/psb_gtt.c: In function ʽpsb_gtt_insertʼ:
> > drivers/staging/gma500/psb_gtt.c:81:33: warning: unused variable ʽdev_privʼ [-Wunused-variable]
> > drivers/staging/gma500/psb_gtt.c: In function ʽpsb_gtt_pinʼ:
> > drivers/staging/gma500/psb_gtt.c:237:2: warning: ʽretʼ may be used uninitialized in this function [-Wuninitialized]
> > 
> > It also fixes up the format string used in DRM_DEBUG() in
> > drivers/staging/gma500/psb_gtt.c:psb_gtt_init() - the string required
> > two arguments but only one was supplied.
> > 
> > While reading through the file I also deleted what trailing whitespace
> > I encountered.
> 
> Unfortunately this file doesn't even exist in the working tree any more.
> Please wait until Greg has taken the patch set I sent him to replace the
> one that didn't apply, and the patch series after that (and quite
> possibly the one after that assuming I can get Cedartrail to work next
> week).
> 
Ok. Thank you for the info. I'll leave gma500 alone for a couple of weeks.

-- 
Jesper Juhl <jj@xxxxxxxxxxxxx>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux