On 07/03/11 02:47, Chris Forbes wrote: > Fixed an uninitialized variable access. In the first two error paths in > max1363_probe(), 'st' is not yet initialized, but its 'reg' member is > accessed anyway. This would most likely crash. Good spot. Please tech TODO files for staging patches. In this case it would have given you the mailing list, now cc'd. > > The intended value for st->reg *is* available at that point in 'reg', > so just use that directly. > > Signed-off-by: Chris Forbes <chrisf@xxxxxxxxx> Acked-by: Jonathan Cameron <jic23@xxxxxxxxx> > --- > drivers/staging/iio/adc/max1363_core.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/iio/adc/max1363_core.c b/drivers/staging/iio/adc/max1363_core.c > index 98cebd2..ebecf14 100644 > --- a/drivers/staging/iio/adc/max1363_core.c > +++ b/drivers/staging/iio/adc/max1363_core.c > @@ -1335,11 +1335,11 @@ error_free_device: > else > iio_device_unregister(indio_dev); > error_disable_reg: > - if (!IS_ERR(st->reg)) > - regulator_disable(st->reg); > + if (!IS_ERR(reg)) > + regulator_disable(reg); > error_put_reg: > - if (!IS_ERR(st->reg)) > - regulator_put(st->reg); > + if (!IS_ERR(reg)) > + regulator_put(reg); > > return ret; > } _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
