On Thu, Jun 30, 2011 at 12:01:08PM -0700, Dan Magenheimer wrote: > +static int zv_curr_dist_counts_show(char *buf) > +{ > + unsigned long i, n, chunks = 0, sum_total_chunks = 0; > + char *p = buf; > + > + for (i = 0; i <= NCHUNKS - 1; i++) { It's more common to write the condition as: i < NCHUNKS. > + n = zv_curr_dist_counts[i]; zv_curr_dist_counts has NCHUNKS + 1 elements so we never print display the final element. I don't know this coe, so I could be wrong but I think that we could make zv_curr_dist_counts only hold NCHUNKS elements. > + p += sprintf(p, "%lu ", n); > + chunks += n; > + sum_total_chunks += i * n; > + } > + p += sprintf(p, "mean:%lu\n", > + chunks == 0 ? 0 : sum_total_chunks / chunks); > + return p - buf; > +} > + > +static int zv_cumul_dist_counts_show(char *buf) > +{ > + unsigned long i, n, chunks = 0, sum_total_chunks = 0; > + char *p = buf; > + > + for (i = 0; i <= NCHUNKS - 1; i++) { > + n = zv_cumul_dist_counts[i]; Same situation. > + p += sprintf(p, "%lu ", n); > + chunks += n; > + sum_total_chunks += i * n; > + } > + p += sprintf(p, "mean:%lu\n", > + chunks == 0 ? 0 : sum_total_chunks / chunks); > + return p - buf; > +} > + regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel