> -----Original Message----- > From: Christoph Hellwig [mailto:hch@xxxxxxxxxxxxx] > Sent: Thursday, June 30, 2011 3:48 PM > To: KY Srinivasan > Cc: gregkh@xxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > devel@xxxxxxxxxxxxxxxxxxxxxx; virtualization@xxxxxxxxxxxxxx; Haiyang Zhang; > Abhishek Kane (Mindtree Consulting PVT LTD); Hank Janssen > Subject: Re: [PATCH 38/40] Staging: hv: storvsc: Fixup srb_status for INQUIRY and > MODE_SENSE > > On Wed, Jun 29, 2011 at 07:39:35AM -0700, K. Y. Srinivasan wrote: > > The current handler on the Windows Host does not correctly handle > > INQUIRY and MODE_SENSE commands with some options. Fixup srb_status > > in these cases since the failure is not fatal. > > > + /* > > + * The current SCSI handling on the host side does > > + * not correctly handle: > > + * INQUIRY command with page code parameter set to 0x80 > > + * MODE_SENSE command with cmd[2] == 0x1c > > + * > > + * Setup srb status so this won't be fatal. > > + */ > > + > > + if ((stor_pkt->vm_srb.cdb[0] == INQUIRY) || > > + (stor_pkt->vm_srb.cdb[0] == MODE_SENSE)) > > + vstor_packet->vm_srb.srb_status = 0; > > Given that the srb_status is only used for debug printks I don't > quite see the point. If people explicitly turn on debugging they > should see that these commands fail, shouldn't they? > The reason I did this was so that I could key off on real failures indicated by srb_status == 0x4 to off-line the device. Regards, K. Y _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
