Re: [PATCH] ath6kl: implement testmode rx command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 27, 2011 at 06:36:10PM +0300, Kalle Valo wrote:
>  #define AR6K_TM_DATA_MAX_LEN 5000
> @@ -1482,11 +1483,83 @@ static const struct nla_policy ar6k_testmode_policy[AR6K_TM_ATTR_MAX + 1] = {
>  				.len = AR6K_TM_DATA_MAX_LEN },
>  };
>  
> +void ar6000_testmode_rx_report_event(struct ar6_softc *ar, void *buf,
> +				     int buf_len)
> +{
> +	kfree(ar->tcmd_rx_report);
> +
> +	ar->tcmd_rx_report = kmemdup(buf, buf_len, GFP_KERNEL);
> +	ar->tcmd_rx_report_len = buf_len;
> +

Can this race?  When we use tcmd_rx_report_len we are under lock,
but it seems like when we set it here, we're not under lock.

regards,
dan carpenter

> +	wake_up(&arEvent);
> +}
> +
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux