On Tue, Jun 07, 2011 at 02:54:25PM +0000, KY Srinivasan wrote: > > > > -----Original Message----- > > From: Christoph Hellwig [mailto:hch@xxxxxxxxxxxxx] > > Sent: Monday, June 06, 2011 7:13 PM > > To: KY Srinivasan > > Cc: gregkh@xxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > > devel@xxxxxxxxxxxxxxxxxxxxxx; virtualization@xxxxxxxxxxxxxx; Haiyang Zhang; > > Abhishek Kane (Mindtree Consulting PVT LTD) > > Subject: Re: [PATCH 12/49] Staging: hv: storvsc: Add a DMI signature to support > > auto-loading > > > > On Mon, Jun 06, 2011 at 03:49:36PM -0700, K. Y. Srinivasan wrote: > > > To support auto-loading the storvsc driver, add a DMI signature. > > > > The storvsc driver is not a DMI driver, but a vmbus driver. As such it > > should have a vmbus table that is used for autoloading, not a dmi one. > > > > A while ago, Greg introduced DMI signatures to these drivers to support > auto-loading. This signature is not used for anything else. For some reason, > this storvsc driver was missing this signature. I added it again to only support > auto-loading. Yes, that was there to solve the original problem of autoloading the driver. But Christoph is correct here, the vmbus needs a way to autoload its own drivers based on the GUID signatures of the devices it finds on the hyperv bus. So the correct thing to do in the long-run is to implement this (which is one of the things the bus needs to do before it can move out of staging). I'll take this patch as-is for now though, as it does solve the immediate issue. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
