Re: [PATCH 1/2] staging: iio replaced kmalloc with local variables.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 06, 2011 at 09:13:29PM +0200, Geert Uytterhoeven wrote:
> On Mon, Jun 6, 2011 at 21:07, anish <anish198519851985@xxxxxxxxx> wrote:
> > From: anish kumar <anish198519851985@xxxxxxxxx>
> >
> > Replace kmalloc with local variables as it was un-necessary and
> 
> Is it really unnecessary?
> Or is this hardware that cannot transfer buffers on the stack?
> IIRC there have been similar problems with SCSI command buffers on the stack.

Yes.  You're right.  These buffers are not allowed to be stack
memory.  The documentation is the section "What memory is DMA'able?"
in Documentation/DMA-API-HOWTO.txt.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux